Align LinuxStrategy async pattern with WindowsStrategy#96
Merged
Conversation
…Strategy Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>
…alls Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix adaptation to .NET 10 new features based on feedback
Align LinuxStrategy async pattern with WindowsStrategy
Jan 6, 2026
JusterZhu
approved these changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the async implementation patterns between platform strategies and fixes a compilation error in the bootstrap configuration. The LinuxStrategy previously used a fire-and-forget Task.Run() pattern while WindowsStrategy properly implemented ExecuteAsync(), creating inconsistent behavior where LinuxStrategy's Execute() would return immediately without waiting for async operations to complete.
Key Changes
- Refactored LinuxStrategy from fire-and-forget
Execute()+Task.Run()to properasync Task ExecuteAsync()implementation - Corrected error message references from "WindowsStrategy" to "LinuxStrategy" in error logging
- Fixed compilation error in GeneralUpdateBootstrap by properly handling value-type default (0) instead of using null coalescing operator for timeout configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/c#/GeneralUpdate.Core/Strategys/LinuxStrategy.cs | Refactored to use native async/await pattern, removed fire-and-forget wrapper, and corrected class name references in error messages |
| src/c#/GeneralUpdate.Core/GeneralUpdateBootstrap.cs | Fixed timeout option handling to check for default value (0) instead of null, as GetOption returns non-nullable int |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinuxStrategyusedExecute()withTask.Run()wrapper whileWindowsStrategyimplementedExecuteAsync()directly, creating inconsistent async patterns across platform strategies.Changes
LinuxStrategy.cs: Replace
Execute()+Task.Run()with nativeExecuteAsync()implementationTask.Run()wrapperWindowsStrategy)GeneralUpdateBootstrap.cs: Fix compilation error from previous commit
GetOption(UpdateOption.DownloadTimeOut)result to avoid duplicate calls0as default, notnull)Both platform strategies now follow identical async patterns:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.